fix(lint): consolidate five more private "Did you mean?" copies onto suggestName - #14757

Fixes #14577

Summary

Follow-up to #14268/#14575: five more validate-*.ts rules in packages/lint/src carried a private suggest/distance pair, re-deriving the same edit-distance-only "Did you mean?" budget that object-graph.ts already exports as suggestName. This PR consolidates all five onto the shared helper.

• Tier 1 — validate-action-name-refs.ts, validate-chart-bindings.ts, validate-searchable-fields.ts: delete the private distance/suggest pair, import suggestName from ./object-graph.js.
• Tier 2 — validate-ai-tool-references.ts, validate-translation-references.ts: keep the rule's own one-line pre-pass (the action_NAME tool-family prefix, and a snake_case namespace-segment match — rule-local knowledge, not the shared helper's business), then delegate the fallback to suggestName instead of a private Levenshtein copy.

object-graph.ts's helper is untouched (#14268 already ruled it — this card consumes it, does not revise it). validate-react-page-props.ts (nearestKnown, fixed budget of at most 2) and validate-rule-schema-formats.ts (nearestRegisteredFormat, exported, case-insensitive, alphabetical tie-break) stay fenced out — both are a different contract on purpose per #14577's triage, and this PR does not touch them.

Population grep (base 4d0d9445a, re-verified at final head 7a17f3bf1)

$ git grep -n "function distance\|function suggest\|function levenshtein" -- packages/lint/src
packages/lint/src/object-graph.ts:399:function distance(...)                    ← untouched, the shared helper's own internals
packages/lint/src/validate-action-name-refs.ts:84/101      ← Tier 1, deleted
packages/lint/src/validate-ai-tool-references.ts:70/87      ← Tier 2, deleted
packages/lint/src/validate-chart-bindings.ts:83/100         ← Tier 1, deleted
packages/lint/src/validate-react-page-props.ts:...editDistance/nearestKnown  ← fenced, untouched
packages/lint/src/validate-rule-schema-formats.ts:...editDistance            ← fenced, untouched
packages/lint/src/validate-searchable-fields.ts:275/289     ← Tier 1, deleted
packages/lint/src/validate-translation-references.ts:159/186 ← Tier 2, deleted

After this PR, function distance is gone from all five files (Tier 1 has zero function distance/suggest left at all; Tier 2 keeps a thin function suggest(...) that is now a one-line pre-pass + return suggestName(...), not a duplicated algorithm):

$ git grep -n "function distance\|function suggest\b" -- packages/lint/src
packages/lint/src/object-graph.ts:399:function distance(...)
packages/lint/src/validate-ai-tool-references.ts:72:function suggest(...)       ← thin wrapper, delegates to suggestName
packages/lint/src/validate-translation-references.ts:173:function suggest(...) ← thin wrapper, delegates to suggestName

Per-site before/after (containment pre-pass now reachable)

The shared helper's containment pre-pass (a candidate that contains the target, or vice versa, scores ahead of any edit-distance match) is now every one of these five rules' behaviour too — it only ever adds a hint where the private copy's budget previously gave none, matching #14268/#14575's precedent.

Existing "Did you mean?" assertions in each file's test suite were re-run and are unchanged (the containment pre-pass never overrides an existing distance-based winner in these fixtures — verified by running each file's test suite before and after). One new pin test was added per file (5 total) covering exactly this containment class — the amount → sum_amount shape the issue names, or its Tier-2 fallback-after-pre-pass-miss equivalent.

Fenced files / helper untouched

$ git diff origin/main --stat -- packages/lint/src/object-graph.ts packages/lint/src/validate-react-page-props.ts packages/lint/src/validate-rule-schema-formats.ts
(empty)

git diff origin/main --stat (final head 7a17f3bf1)

 .../lint/src/validate-action-name-refs.test.ts     | 15 ++++++++
 packages/lint/src/validate-action-name-refs.ts     | 34 ++----------------
 .../lint/src/validate-ai-tool-references.test.ts   | 16 +++++++++
 packages/lint/src/validate-ai-tool-references.ts   | 34 +++---------------
 packages/lint/src/validate-chart-bindings.test.ts  | 30 ++++++++++++++++
 packages/lint/src/validate-chart-bindings.ts       | 38 +++-----------------
 .../lint/src/validate-searchable-fields.test.ts    | 19 ++++++++++
 packages/lint/src/validate-searchable-fields.ts    | 35 ++-----------------
 .../src/validate-translation-references.test.ts    | 16 +++++++++
 .../lint/src/validate-translation-references.ts    | 40 +++++-----------------
 10 files changed, 117 insertions(+), 160 deletions(-)
 + .changeset/lint-suggest-name-consolidation-tier2.md (new)

Tests

• pnpm --filter @objectstack/lint exec vitest run --maxWorkers=2 against the five test files — 164 passed, 0 failed (5 files).
• pnpm --filter @objectstack/lint test (full package suite, includes the 5 new pin tests) — 93 test files passed, 2841 passed / 5 skipped (2846), run twice: once at merge-base 4d0d9445a, once at final head 7a17f3bf1 — identical results both times.
• pnpm --filter @objectstack/lint typecheck — clean (pre-existing test-typecheck-debt.json entries unrelated to this change, unchanged: 2 file(s)/6 error(s)/2 pinned signatures, shrink-only, @ts-expect-error 退役 pin 在 packages/spec 里是幽灵检查:tsconfig 把 **/*.test.ts 排除出唯一的 tsc --noEmit #5286).
• Dependency closure built first: pnpm --filter '@objectstack/lint^...' build (spec, formula) before any test run.

Gates

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands against the five files plus the changeset derived 28 command(s). All 28 run at final head 7a17f3bf1:

• 26/28 exit 0.
• node scripts/check-test-completeness.mjs — exit 3, self-declared NOT MEASURED ("nothing was measured... pass a saved turbo run test log, or record this gate as NOT MEASURED" — needs a turbo run test log this local run does not have).
• pnpm check:dual-build-cjs-loads — exit 3, self-declared PREREQUISITE NOT MET ("this gate reads built output, and some package has no dist/" — needs a full repo-wide pnpm build across ~79 packages, out of scope for a targeted local run; CI's build step covers it).

Both are explicit self-reports, not failures — captured with exit code read before any pipe.

Merged origin/main twice during this run (once at 5258b63f8, once at 7a17f3bf1, both clean fast-forwards, neither touched packages/lint/) — the final test+typecheck pair was re-run at 7a17f3bf1 to confirm the result still holds at the pushed head.

Scope

File surface: the five rule files + their test files + one changeset — exactly the claimed surface, nothing else touched. @objectstack/lint patch changeset included, describing the hint-quality change per rule.

Generated by Claude Code